Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: fix CTAS when selecting from some internal virtual tables #105359

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jun 22, 2023

Backport 1/1 commits from #105324.

/cc @cockroachdb/release


This commit fixes an oversight where we forgot to set the SQL stats provider in some code paths (namely when NewInternalPlanner is called, one example is backfilling query into table that powers CREATE TABLE AS and CREATE MATERIALIZED VIEW AS features), and this is now fixed.

Fixes: #76710.

Release note (bug fix): Previously, CockroachDB would crash when evaluating CREATE TABLE .. AS or CREATE MATERIALIZED VIEW .. AS statements when AS clause selected data from
crdb_internal.cluster_statement_statistics or
crdb_internal.cluster_transaction_statistics virtual tables. The bug has been present since at least 22.1 and is now fixed.

Release justification: bug fix.

This commit fixes an oversight where we forgot to set the SQL stats
provider in some code paths (namely when `NewInternalPlanner` is called,
one example is backfilling query into table that powers CREATE TABLE AS
and CREATE MATERIALIZED VIEW AS features), and this is now fixed.

Release note (bug fix): Previously, CockroachDB would crash when
evaluating CREATE TABLE .. AS or CREATE MATERIALIZED VIEW .. AS
statements when AS clause selected data from
`crdb_internal.cluster_statement_statistics` or
`crdb_internal.cluster_transaction_statistics` virtual tables. The bug
has been present since at least 22.1 and is now fixed.
@yuzefovich yuzefovich requested a review from rafiss June 22, 2023 16:32
@yuzefovich yuzefovich requested a review from a team as a code owner June 22, 2023 16:32
@blathers-crl
Copy link

blathers-crl bot commented Jun 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich merged commit fc870a7 into cockroachdb:release-22.2 Jun 22, 2023
@yuzefovich yuzefovich deleted the backport22.2-105324 branch June 22, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants