Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: improve timeperiod display #105312

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jun 21, 2023

Backport 1/1 commits from #105157.

/cc @cockroachdb/release


Previously, the period being shown on SQL Activity page could be confusing, since we no longer refresh the page automatically. This could result in a scenario where a query is executed, the user click on Apply on the Search Criteria on X:05, but the page shows that the results goes up to X:59, but then if you executed new statements they won't show until Apply is clicked again, but because we still show the message that the results are up to X:59 this is misleading.
This commit updates the value being displayed to use the time the request was made, so we know the end window value, and even if the user changes page and go back, the value is still the X:05, making more obvious they need to click on Apply again if they want to see newer results.

Here an example of the previous behaviour on Transactions page and the new Behaviour on Statement page:
(to clarify, this PR make this update on Statement, Statement Details, Transaction and Transaction Details pages)
https://www.loom.com/share/ec19aa79a5144aea9e44bec59a5101a4

Epic: none
Release note: None


Release justification: UX improvement

@maryliag maryliag requested review from a team June 21, 2023 21:02
@blathers-crl
Copy link

blathers-crl bot commented Jun 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the period being shown on SQL Activity page
could be confusing, since we no longer refresh the page
automatically. This could result in a scenario where
a query is executed, the user click on Apply on the Search
Criteria on X:05, but the page shows that the results
goes up to X:59, but then if you executed new statements
they won't show until Apply is clicked again, but because
we still show the message that the results are up to X:59
this is misleading.
This commit updates the value being displayed to use the
time the request was made, so we know the end window value,
and even if the user changes page and go back, the value
is still the X:05, making more obvious they need to click
on Apply again if they want to see newer results.

Epic: none

Release note: None
@maryliag maryliag force-pushed the backport23.1-105157 branch from 914b734 to 590fb64 Compare June 21, 2023 21:06
Copy link
Contributor

@gtr gtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit fd10d2f into cockroachdb:release-23.1 Jun 22, 2023
@maryliag maryliag deleted the backport23.1-105157 branch June 22, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants