sql: don't pass a nil clock in kv_test #10526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use the server's clock rather than manhunt a new one. LGTM otherwise |
|
Er, making. |
jordanlewis
force-pushed
the
fix-kv-test
branch
from
cfbae01 to
4d96fd6
Compare
|
Done. |
The Benchmark tests panic due to `kv_test` passing a `nil` clock to `rpc.NewContext`. Fix this. See cockroachdb#8081
jordanlewis
force-pushed
the
fix-kv-test
branch
from
4d96fd6 to
e955b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Benchmark tests panic due to
kv_testpassing anilclock torpc.NewContext. Fix this. See #8081This change is