Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: logictest: fix crdb_internal flake #105194

Merged

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Jun 20, 2023

This commit fixes an incorrect change to a test that was introduced
in #104735. The test was flaky instead of consistently failing because
it uses the retry option.

Fixes #104952

Release justification: This is a test-only change.

Release note: None

This commit fixes an incorrect change to a test that was introduced
in cockroachdb#104735. The test was flaky instead of consistently failing because
it uses the `retry` option.

Fixes cockroachdb#104952

Release note: None
@mgartner mgartner requested review from ecwall, rharding6373 and a team June 20, 2023 14:44
@blathers-crl
Copy link

blathers-crl bot commented Jun 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner
Copy link
Collaborator Author

mgartner commented Jun 20, 2023

TFTRs!

@mgartner

This comment was marked as off-topic.

@craig

This comment was marked as off-topic.

@mgartner mgartner merged commit f7a5282 into cockroachdb:release-22.2 Jun 20, 2023
@mgartner mgartner deleted the fix-crdb-internal-logic-test branch June 20, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants