Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: skip pgbench if not on PATH #10509

Merged
merged 1 commit into from
Nov 7, 2016
Merged

sql: skip pgbench if not on PATH #10509

merged 1 commit into from
Nov 7, 2016

Conversation

dt
Copy link
Member

@dt dt commented Nov 7, 2016

Currently blocking #8081

This change is Reviewable

@tamird
Copy link
Contributor

tamird commented Nov 7, 2016

:lgtm:

please mention the issue.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


pkg/sql/pgbench_test.go, line 24 at r1 (raw file):

  "math/rand"
  "net/url"
  osexec "os/exec"

why the alias?


Comments from Reviewable

@dt
Copy link
Member Author

dt commented Nov 7, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


pkg/sql/pgbench_test.go, line 24 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

why the alias?

there's already a symbol `exec` in the sql package (in txn_restart_test.go).

Comments from Reviewable

@tamird
Copy link
Contributor

tamird commented Nov 7, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


pkg/sql/pgbench_test.go, line 24 at r1 (raw file):

Previously, dt (David Taylor) wrote…

there's already a symbol exec in the sql package (in txn_restart_test.go).

which has one caller 🤦

Comments from Reviewable

@jordanlewis
Copy link
Member

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from Reviewable

@dt
Copy link
Member Author

dt commented Nov 7, 2016

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


pkg/sql/pgbench_test.go, line 24 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

which has one caller 🤦

Done.

Comments from Reviewable

@tamird
Copy link
Contributor

tamird commented Nov 7, 2016

Can you mention the issue in the commit message, not just the PR description?


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@dt
Copy link
Member Author

dt commented Nov 7, 2016

Done.

@tamird
Copy link
Contributor

tamird commented Nov 7, 2016

Great. Feel free to unassign yourself from #8081 and kick off a benchmark run when this merges.

@dt dt merged commit 375eee3 into cockroachdb:master Nov 7, 2016
@dt dt deleted the pgb branch November 7, 2016 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants