Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: ui: Redirect Range Report page to Hot Ranges page #104980

Merged
merged 1 commit into from
Jun 20, 2023
Merged

release-23.1: ui: Redirect Range Report page to Hot Ranges page #104980

merged 1 commit into from
Jun 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 15, 2023 •
edited by gtr
Loading

Backport 1/1 commits from #104677 on behalf of @gtr.

/cc @cockroachdb/release

Fixes: #102377.

Previously, when a user selected a range ID from the Hot Ranges page,
the left side menu would switch to Advanced Debug and the back button
would also redirect to the Advanced Debug page. This commit ensures that
when a range ID is selected, the left side menu will stay on the Hot
Ranges page and also changes the back button to redirect back to the
Hot Ranges page.

image

Release note (ui change): The Range Report page (route
/reports/range/:rangeID) shows the "Hot Ranges" menu item as
highlighted in the left side menu. The back button in the Range Report
page redirects back to the Hot Ranges page.

Release justification: small bug fix

@gtr
ui: Redirect Range Report page to Hot Ranges page
4736a8a 
Fixes: #102377.

Previously, when a user selected a range ID from the Hot Ranges page,
the left side menu would switch to Advanced Debug and the back button
would also redirect to the Advanced Dedug page. This commit ensures that
when a range ID is selected, the left side menu will stay on the Hot
Ranges page and also changes the back button to redirect back to the
Hot Ranges page.

Release note (ui change): The Range Report page (route
`/reports/range/:rangeID`) shows the "Hot Ranges" menu item as
highlighted in the left side menu. The back button in the Range Report
page redirects back to the Hot Ranges page.
@blathers-crl blathers-crl bot requested a review from a team June 15, 2023 15:18
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104677 branch 2 times, most recently from 2705f5e to 4736a8a Compare June 15, 2023 15:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 15, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 15, 2023 •
edited by gtr
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from j82w June 15, 2023 15:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

maryliag
maryliag approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w)

@gtr
Copy link
Contributor

gtr commented Jun 20, 2023

TFTR!

@gtr gtr merged commit b4ddd01 into release-23.1 Jun 20, 2023
@gtr gtr deleted the blathers/backport-release-23.1-104677 branch June 20, 2023 15:05
@cockroach-teamcity cockroach-teamcity mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

@j82w j82w Awaiting requested review from j82w

Assignees

@gtr gtr

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @gtr @maryliag