Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: backport recent improvements #104882

Merged

Conversation

renatolabs
Copy link
Contributor

This backports a couple of recent improvements to the roachtest infrastructure that are useful to have in the 23.1 branch. Specifically, this backport includes all commits from #101254, #102622, and #102636.

Epic: none

Release notes: none

Release justification: test-only changes.

Miral Gadani added 4 commits June 14, 2023 10:32
of marker.* files

Epic: none
Fixes: cockroachdb#95170

Release note: None
for running post test validations. This avoids connecting to drained
or decommissioned nodes.

Epic: none
Release note: none
Fixes: cockroachdb#102603
of all nodes in test teardown. Validations can use a db connection
from any node which has a status of 200.

Epic: none
Release note: none
Informs: cockroachdb#102603
@renatolabs renatolabs requested a review from a team as a code owner June 14, 2023 14:38
@renatolabs renatolabs requested review from srosenberg and smg260 and removed request for a team June 14, 2023 14:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

smg260

This comment was marked as duplicate.

Copy link
Contributor

@smg260 smg260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @srosenberg)

@renatolabs renatolabs merged commit 69d57f3 into cockroachdb:release-23.1 Jun 14, 2023
@renatolabs renatolabs deleted the roachtest-improvements-backport branch June 14, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants