Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvnemesis: add TestingKnobs.OnRangeSpanningNonTxnalBatch back #104867

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Jun 14, 2023

#103963 accidentally removed a testing knob which caused #104865.
This commit adds the testing knob back.

Fixes: #104865
Release note: none

@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@wenyihu6 wenyihu6 requested a review from tbg June 14, 2023 12:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

cockroachdb#103963 accidentally removed a testing knob which caused cockroachdb#104865.
This commit adds the testing knob back.

Fixes: cockroachdb#104865
Release note: none
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I wouldn't usually do this right away, but since the code change is so small and I think the tests will be pretty flaky without this:

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

👎 Rejected by too few approved reviews

@tbg tbg marked this pull request as ready for review June 14, 2023 12:17
@tbg tbg requested a review from a team as a code owner June 14, 2023 12:17
@tbg
Copy link
Member

tbg commented Jun 14, 2023

bors r+

@wenyihu6 wenyihu6 requested review from a team and removed request for a team June 14, 2023 12:18
@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

Build succeeded:

@craig craig bot merged commit f35e066 into cockroachdb:master Jun 14, 2023
@wenyihu6 wenyihu6 deleted the testingknob branch June 14, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvnemesis: TestKVNemesisSingleNode: committed deleteRangeUsingTombstone non-atomic timestamps
3 participants