Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server: don't double-count RAID volumes in disk metrics #104806

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

itsbilal
Copy link
Contributor

@itsbilal itsbilal commented Jun 13, 2023

Backport 1/1 commits from #104640.

/cc @cockroachdb/release

Release justification: Low risk, metrics-only observability improvement.


Previously, we wouldn't exclude volumes from disk counters that are likely to be double-counted such as RAID logical volumes that are composed of physical volumes that are also independently present in disk metrics. This change adds a regex-based filter, overridable with env vars, that excludes common double-counted volume patterns.

Fixes #97867.

Epic: none

Release note (bug fix): Avoids double-counting disk read/write bytes in disk metrics if Cockroach observes volumes that are likely to be duplicated in reported disk counters, such as RAID logical vs physical volumes.

@itsbilal itsbilal requested a review from a team June 13, 2023 20:24
@itsbilal itsbilal self-assigned this Jun 13, 2023
@itsbilal itsbilal requested a review from a team June 13, 2023 20:24
@itsbilal itsbilal requested a review from a team as a code owner June 13, 2023 20:24
@blathers-crl
Copy link

blathers-crl bot commented Jun 13, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@itsbilal itsbilal removed their assignment Jun 13, 2023
Previously, we wouldn't exclude volumes from disk counters
that are likely to be double-counted such as RAID logical
volumes that are composed of physical volumes that are also
independently present in disk metrics. This change adds a
regex-based filter, overridable with env vars, that excludes
common double-counted volume patterns.

Fixes cockroachdb#97867.

Epic: none

Release note (bug fix): Avoids double-counting disk read/write bytes
in disk metrics if Cockroach observes volumes that are likely to
be duplicated in reported disk counters, such as RAID logical vs
physical volumes.
@itsbilal itsbilal force-pushed the backport23.1-104640 branch from cc37138 to 2627b2e Compare June 14, 2023 03:11
@itsbilal
Copy link
Contributor Author

TFTR!

@itsbilal itsbilal merged commit 88f9534 into cockroachdb:release-23.1 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants