Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils: skip TestRestart #104768

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

msbutler
Copy link
Collaborator

Informs #104740

Release note: None

Epic: none

@msbutler msbutler added the T-testeng TestEng Team label Jun 13, 2023
@msbutler msbutler requested review from knz and stevendanna June 13, 2023 10:24
@msbutler msbutler self-assigned this Jun 13, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@@ -12,6 +12,7 @@ package testcluster

import (
"context"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
Copy link
Contributor

@erikgrinaker erikgrinaker Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the linter will yell at you for the location.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, fixed manually. my version of crlfmt cannot fix this :(

@msbutler msbutler force-pushed the butler-skip-test-restart branch from f63868e to edf1f21 Compare June 13, 2023 10:26
Informs cockroachdb#104740

Release note: None

Epic: none
@msbutler msbutler force-pushed the butler-skip-test-restart branch from edf1f21 to 9e7711c Compare June 13, 2023 10:34
@msbutler
Copy link
Collaborator Author

bors r+ single on

@craig
Copy link
Contributor

craig bot commented Jun 13, 2023

Build succeeded:

@craig craig bot merged commit 35d6537 into cockroachdb:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testeng TestEng Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants