Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: attempt to explain ProposalData lifecycle #104658

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

tbg
Copy link
Member

@tbg tbg commented Jun 9, 2023

Epic: CRDB-25287
Release note: None

@blathers-crl
Copy link

blathers-crl bot commented Jun 9, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/kv/kvserver/replica_proposal.go Outdated Show resolved Hide resolved
pkg/kv/kvserver/replica_proposal.go Outdated Show resolved Hide resolved
pkg/kv/kvserver/replica_proposal.go Show resolved Hide resolved
@tbg tbg marked this pull request as ready for review June 14, 2023 10:31
@tbg tbg force-pushed the propdata-lifecycle-doc branch from e5efaa2 to b295466 Compare June 14, 2023 10:31
@tbg tbg requested a review from a team June 14, 2023 10:31
@tbg
Copy link
Member Author

tbg commented Jun 14, 2023

TFTR!

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

Build failed:

@tbg
Copy link
Member Author

tbg commented Jun 14, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 14, 2023

Build succeeded:

@craig craig bot merged commit f35e066 into cockroachdb:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants