Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-console: rename c2c dashboard to Physical Cluster Replication #104645

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

lidorcarmel
Copy link
Contributor

The recently added dashboard is called Cross-Cluster Replication, and this commit renames it to Physical Cluster Replication.

c2c is now called Physical Replication, and in contexts where it's not obvious we should be clear that this is Cluster replication and not Raft.

Epic: none

Release note: None

@lidorcarmel lidorcarmel requested review from stevendanna and a team June 9, 2023 03:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@lidorcarmel
Copy link
Contributor Author

FYI @livlobo , @adityamaru , @dt

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I still kinda like the old name better, but this die is cast.

@lidorcarmel
Copy link
Contributor Author

Thanks!
bors r+

@craig
Copy link
Contributor

craig bot commented Jun 12, 2023

This PR was included in a batch that timed out, it will be automatically retried

@rickystewart
Copy link
Collaborator

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 12, 2023

Canceled.

@rickystewart
Copy link
Collaborator

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 12, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

The recently added dashboard is called `Cross-Cluster Replication`, and
this commit renames it to `Physical Cluster Replication`.

c2c is now called Physical Replication, and in contexts where it's not
obvious we should be clear that this is Cluster replication and not Raft.

Epic: none

Release note: None
@lidorcarmel lidorcarmel force-pushed the lidor_c2c_dashboard_rename branch from 32b61ec to e1556ba Compare June 13, 2023 02:18
@lidorcarmel
Copy link
Contributor Author

bors r+

@healthy-pod
Copy link
Contributor

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 13, 2023

Canceled.

@healthy-pod
Copy link
Contributor

bors r+ single on

@craig
Copy link
Contributor

craig bot commented Jun 13, 2023

Build succeeded:

@craig craig bot merged commit 2271419 into cockroachdb:master Jun 13, 2023
@lidorcarmel lidorcarmel deleted the lidor_c2c_dashboard_rename branch July 14, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants