storage: increase capacity of PointKeyFilters slice #104560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jbowens
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)
|
TFTR! |
|
bors r=jbowens |
|
Build failed: |
sumeerbhola
force-pushed
the
bpf_slice_cap
branch
from
f485205 to
9419a93
Compare
This is to conform to the recently introduced performance recommendation in pebble.IterOptions. Informs cockroachdb/pebble#2465 Epic: none Release note: None
sumeerbhola
force-pushed
the
bpf_slice_cap
branch
from
9419a93 to
ba053dd
Compare
|
bors r=jbowens |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Looks like there are bors issues and the workaround is: bors r+ single on |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to conform to the recently introduced performance recommendation in pebble.IterOptions.
Informs cockroachdb/pebble#2465
Epic: none
Release note: None