server: don't write to the test server config in maybeStartDefaultTestTenant
#104503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stTenant` The server config can be read asynchronously by the server controller when starting servers in the background. So a write there is racy. (If we later discover we really need to write to the server config, we'd need to introduce a mutex for that.) Release note: None
|
This change is |
herkolategan
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajstorm, @knz, @smg260, and @stevendanna)
pkg/server/testserver.go line 548 at r1 (raw file):
// If not enterprise enabled, we won't be able to use SQL Servers so eat // the error and return without creating/starting a SQL server. ts.cfg.DisableDefaultTestTenant = true
Some CI failures unfortunately popped up. This somehow exposed a different issue where testing.TB is not set in a call to StartServerRaw causing a panic when it tries to log the tenant message, which I think should be fixed in either case. And additionally logic.go also makes some assumptions by calling TestCluster.StartedDefaultTestTenant() which gets it from the above cfg. Not sure if patching these or introducing a mutex will be lower impact.
|
Replacing with #108762. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-18499
Fixes #104500.
The server config can be read asynchronously by the server controller when starting servers in the background. So a write there is racy.
(If we later discover we really need to write to the server config, we'd need to introduce a mutex for that.)
Release note: None