-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: go.mod: use the crdb fork for etcd #104499
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Lint is broken. I couldn't get
Same behaviour prior to this PR, if I'm just on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the go mod issues. Maybe dev-inf can help us?
51a91cd
to
51edcf5
Compare
In order to cherry-pick bug fixes from upstream etcd-io/raft, use our fork. The fixes will be manually added because the etcd/raft has migrated to its own repo at etcd-io/raft. Release justification: necessary to cherry-pick a bug fix from upstream Release note: None
@tbg @erikgrinaker Could you take another look? I updated deps in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded: |
In order to cherry-pick bug fixes from upstream etcd-io/raft, use our fork. The fixes will be manually added because the etcd/raft has migrated to its own repo at etcd-io/raft.
Release justification: necessary to cherry-pick a bug fix from upstream
Epic: None
Release note: None