Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: mark targets as being no-remote-exec instead of no-remote #104454

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

rickystewart
Copy link
Collaborator

no-remote implies no-remote-cache as well. Properly these targets can be cached remotely, they just can't be executed remotely.

Epic: CRDB-8308
Release note: None

`no-remote` implies `no-remote-cache` as well. Properly these targets
can be cached remotely, they just can't be executed remotely.

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart requested a review from healthy-pod June 6, 2023 23:13
@rickystewart rickystewart requested review from a team as code owners June 6, 2023 23:13
@rickystewart rickystewart requested a review from msirek June 6, 2023 23:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator Author

bors r=healthy-pod

@craig
Copy link
Contributor

craig bot commented Jun 7, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 7, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@rickystewart
Copy link
Collaborator Author

Not sure what this garbage is.

bors r=healthy-pod

@craig
Copy link
Contributor

craig bot commented Jun 7, 2023

Build succeeded:

@craig craig bot merged commit 502b113 into cockroachdb:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants