Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexrec: improve recommendations for queries with inequalities #104208

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

qiyanghe1998
Copy link
Contributor

@qiyanghe1998 qiyanghe1998 commented Jun 1, 2023

Fixes #102206

As for the tests, since !=, IS DISTINT FROM and IS NOT are categorized as range
index, so I copied similar tests with "R": R, EQ + R, J + R, EQ + J + R.

Release note: None

Epic: None

@qiyanghe1998 qiyanghe1998 requested a review from a team as a code owner June 1, 2023 14:51
@qiyanghe1998 qiyanghe1998 requested a review from cucaroach June 1, 2023 14:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner self-requested a review June 1, 2023 15:05
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :lgtm: Just left some optional nits.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach and @qiyanghe1998)


-- commits line 2 at r1:
nit: It's hard to make titles fit in ~72 characters — I don't always manage it — but you can try to make them less specific and put the details in the commit message body. For example, "indexrec: improve recommendations for queries with inequalities" is an option.


-- commits line 7 at r1:
nit: "changed" makes it sound like you altered existing tests. maybe so I copied similar tests with "R": ...

…index recommendations

Fixes cockroachdb#102206

As for the tests, since !=, IS DISTINT FROM and IS NOT are categorized as range
index, so I copied similar tests with "R": R, EQ + R, J + R, EQ + J + R.

Release note: None
@qiyanghe1998 qiyanghe1998 force-pushed the 102206-add-noteq-and-isnot branch from 6e7fdde to 5f50b7a Compare June 1, 2023 15:40
@qiyanghe1998 qiyanghe1998 changed the title indexrec: include != and IS DISTINCT FROM and IS NOT columns in index recommendations indexrec: improve recommendations for queries with inequalities Jun 1, 2023
@qiyanghe1998
Copy link
Contributor Author

-- commits line 7 at r1:

Previously, mgartner (Marcus Gartner) wrote…

nit: "changed" makes it sound like you altered existing tests. maybe so I copied similar tests with "R": ...

fixed

@qiyanghe1998
Copy link
Contributor Author

-- commits line 2 at r1:

Previously, mgartner (Marcus Gartner) wrote…

nit: It's hard to make titles fit in ~72 characters — I don't always manage it — but you can try to make them less specific and put the details in the commit message body. For example, "indexrec: improve recommendations for queries with inequalities" is an option.

Thanks. Great advice, fixed.

@qiyanghe1998
Copy link
Contributor Author

bors r+

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @cucaroach)

@craig
Copy link
Contributor

craig bot commented Jun 1, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 1, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 1, 2023

Build succeeded:

@craig craig bot merged commit edcd40a into cockroachdb:master Jun 1, 2023
@qiyanghe1998 qiyanghe1998 deleted the 102206-add-noteq-and-isnot branch June 1, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opt: include != and IS DISTINCT FROM and IS NOT NULL columns in index recommendations
3 participants