storage: prevent iter panic on meta1 split key #104082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
It was possible that a load based split was suggested for `meta1`, which would call `MVCCFirstSplitKey` and panic as the `meta1` start key `\Min` is local, whilst the `meta1` end key is global `0x02 0xff 0xff`. Add a check that the start key is greater than the `meta1` end key before processing in `MVCCFirstSplitKey` to prevent the panic. Note `meta1` would never be split regardless, as `storage.IsValidSplitKey` would fail after finding a split key. Also note that if the desired split key is a local key, the same problem doesn't exist as the minimum split key would be used to seek the first split key instead. Fixes: cockroachdb#104007 Release note: None
kvoli
force-pushed
the
230530.split-first-panic
branch
from
2b4d2b9 to
30caa00
Compare
kvoli
changed the title
kvoli
requested review from
itsbilal,
nvanbenschoten,
erikgrinaker and
sumeerbhola
|
TYFTR bors r=itsbilal |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible that a load based split was suggested for
meta1, whichwould call
MVCCFirstSplitKeyand panic as themeta1start key\Minis local, whilst themeta1end key is global0x02 0xff 0xff.Add a check that the start key is greater than the
meta1end key beforeprocessing in
MVCCFirstSplitKeyto prevent the panic.Note
meta1would never be split regardless, asstorage.IsValidSplitKeywould fail after finding a split key.Also note that if the desired split key is a local key, the same problem
doesn't exist as the minimum split key would be used to seek the first
split key instead.
Fixes: #104007
Release note: None