-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: don't apply quota pool to lease requests #104026
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Lease requests and transfers are latency sensitive and small, so we allow them to bypass the quota pool. This is particularly important for expiration lease extensions, which happen every 3 seconds. During TPCC imports, the quota pool was often found to delay lease requests by as much as 3 seconds. Epic: none Release note: None
4a94eaa
to
ff8ccbe
Compare
Ran a TPCC import with this, and didn't see any lease requests take much more than a second end-to-end except for reproposals during leader changes (#104024). Previously, I often saw delays of 3 seconds or more, sufficient for the range to lose its lease. So this seems fairly effective. |
bors r+ |
@irfansharif We'll want to do something similar with replication AC, and let lease requests through as soon as possible. Can you add that to #98308 or a follow-up PR? I'm not sure how relevant it is, since lease requests are often sent directly to the replica and bypass a lot of the store AC and such (lease transfers still go via the store though). |
Build succeeded: |
Still relevant. Added to #104154. |
Lease requests and transfers are latency sensitive and small, so we allow them to bypass the quota pool. This is particularly important for expiration lease extensions, which happen every 3 seconds.
During TPCC imports, the quota pool was often found to delay lease requests by as much as 3 seconds.
Resolves #98124.
Epic: none
Release note: None