-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: roachtest: add failover
variants for partial network partitions
#103974
Merged
msbutler
merged 5 commits into
cockroachdb:release-23.1
from
erikgrinaker:backport23.1-103254
May 27, 2023
Merged
release-23.1: roachtest: add failover
variants for partial network partitions
#103974
msbutler
merged 5 commits into
cockroachdb:release-23.1
from
erikgrinaker:backport23.1-103254
May 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves readability of zone configs in `failover` tests, by tweaking the APIs. It also fixes a bug which placed replicas on the wrong nodes in `failover/partial/lease-liveness`. Epic: none Release note: None
This test did not sufficiently constrain range/lease placement, which caused occasional permanent unavailability as it randomly hit other failure modes than the one it's trying to test. This patch makes the test more prescriptive, by separating out the system ranges, SQL gateways, liveness leaseholder, and user ranges, and only introducing a partial partition between a user leaseholder and the liveness leaseholder. Epic: none Release note: None
This patch adds a roachtest that benchmarks the pMax unavailability during a partial network partition between a SQL gateway and a leaseholder. We currently don't handle this failure mode at all, and expect this to result in permanent unavailability. Epic: none Release note: None
This patch adds `COCKROACH_DISABLE_LEADER_FOLLOWS_LEASEHOLDER` which will disable colocation of the Raft leader and leaseholder. This is useful for tests. Epic: none Release note: None
erikgrinaker
requested review from
herkolategan and
smg260
and removed request for
a team
May 26, 2023 20:47
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
This patch adds a roachtest that benchmarks unavailability during a partial partition between a Raft leader and leaseholder. Epic: none Release note: None
erikgrinaker
force-pushed
the
backport23.1-103254
branch
from
May 26, 2023 21:37
215cf69
to
3f53f25
Compare
msbutler
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5/5 commits from #103254.
/cc @cockroachdb/release
Release justification: test-only change.
roachtest: improve zone config readability in failover tests
This patch improves readability of zone configs in
failover
tests, by tweaking the APIs. It also fixes a bug which placed replicas on the wrong nodes infailover/partial/lease-liveness
.roachtest: improve
failover/partial/lease-liveness
This test did not sufficiently constrain range/lease placement, which caused occasional permanent unavailability as it randomly hit other failure modes than the one it's trying to test.
This patch makes the test more prescriptive, by separating out the system ranges, SQL gateways, liveness leaseholder, and user ranges, and only introducing a partial partition between a user leaseholder and the liveness leaseholder.
roachtest: add
failover/partial/lease-gateway
This patch adds a roachtest that benchmarks the pMax unavailability during a partial network partition between a SQL gateway and a leaseholder. We currently don't handle this failure mode at all, and expect this to result in permanent unavailability.
kvserver: add
COCKROACH_DISABLE_LEADER_FOLLOWS_LEASEHOLDER
This patch adds
COCKROACH_DISABLE_LEADER_FOLLOWS_LEASEHOLDER
which will disable colocation of the Raft leader and leaseholder. This is useful for tests.roachtest: add
failover/partial/lease-leader
This patch adds a roachtest that benchmarks unavailability during a partial partition between a Raft leader and leaseholder.
Resolves #94614.
Touches #93503.
Epic: none
Release note: None