tracing: enable fine-grained redactability for unstructured events #103884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
dhartunian
reviewed
May 31, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @knz)
-- commits line 4 at r1:
nit: grained
pkg/util/tracing/tracer.go line 111 at r1 (raw file):
settings.TenantWritable, "trace.redactable.enabled", "set to true to enable finer-grain redactability for unstructured events in traces",
nit: grained
knz
commented
Jun 1, 2023
There was a problem hiding this comment.
Reviewable status:
Previously, dhartunian (David Hartunian) wrote…
nit: grained
Fixed.
pkg/util/tracing/tracer.go line 111 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
nit: grained
Fixed.
knz
force-pushed
the
20230525-redactable-traces
branch
from
69dfd05 to
62a0ba0
Compare
This enables finer-grained redraction for unstructured events in traces. See cockroachdb#103883 for a discussion. (This can be reverted in case performance is found to be unacceptable.) Release note: None
knz
force-pushed
the
20230525-redactable-traces
branch
from
62a0ba0 to
415f82d
Compare
|
TFYR bors r=dhartunian |
|
👎 Rejected by too few approved reviews |
dhartunian
approved these changes
Jun 1, 2023
|
TFYR! bors r=dhartunian |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
103180: sql: more redactable details about traces in logs r=abargainier,michae2 a=knz Followup to #103034. Fixes #103319. Prior to this patch, the logging output for SQL statements / txns that exceeded the tracing threshold would mark the entire SQL statement syntax and the entire trace as redactable. This commit improves the situation by making the statement syntax and the trace more finely redactable, ensuring that more details are included after redaction. Note: the redaction is still pretty strong by default, as long as `trace.redactable.enabled` defaults to `false`. See #103884. Release note (sql change): The logging output emitted when `sql.trace.stmt.enable_threshold` or `sql.trace.txn.enable_threshold` are set is now emited on the SQL_EXEC channel instead of DEV as previously. Epic: CRDB-27642 Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103883
Epic: CRDB-27642
This enables finer-grain redraction for unstructured events in traces. See #103883 for a discussion. (This can be reverted in case performance is found to be unacceptable.)
Release note: None