ci: ensure logictests generated code is up to date #103810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
healthy-pod
force-pushed
the
check-gen-code
branch
from
066d2fd to
f613976
Compare
rickystewart
approved these changes
May 24, 2023
| @@ -39,5 +39,8 @@ check_workspace_clean 'dev_generate' "Run \`./dev generate\` to automatically re | |||
| # docs. | |||
| bazel run @go_sdk//:bin/go --ui_event_filters=-DEBUG,-info,-stdout,-stderr --noshow_progress mod tidy | |||
| check_workspace_clean 'go_mod_tidy' "Run \`go mod tidy\` to automatically regenerate these." | |||
| # Run `generate-logictest` and ensure nothing changes. | |||
| bazel run //pkg/cmd/generate-logictest -- -out-dir="$PWD" | |||
| check_workspace_clean 'generate_logictest' "Run \`./dev gen logictest\` to automatically regenerate these." | |||
There was a problem hiding this comment.
Nit: dev gen testlogic is the version we use in the code and is I think the "official" spelling, so maybe use it here. ./dev gen logictest is a synonym so it still works.
This code change ensures that generated BUILD files for logictests are always up to date. Epic: none Release note: None
healthy-pod
force-pushed
the
check-gen-code
branch
from
f613976 to
16f9ba5
Compare
|
bors r=rickystewart |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change ensures that generated BUILD files for logictests are always up to date.
Release note: None
Epic: none