changefeedccl: freeze the hashing algorithm #103808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit will freeze the partitioning logic in its current state. This commit ensures that that change, as well as future library updates, don't accidentally change the hashing logic. For example, Sarama intends to change how it handles negative values in a future update. Release note: None
This is a no-op change meant to defend against future changes in the default Sarama hashing algorithm. Fixes cockroachdb#101779. Release note: None
|
This change is |
miretskiy
approved these changes
May 24, 2023
|
bors r=[miretskiy] |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In almost every place where we need consistent hashing, we specify it. But in the Kafka sink, we just used Sarama's default, which is subject to change. This PR specifies the algorithm explicitly there too, and adds a test with hardcoded values so that future updates can't cause inconsistent behavior in a running changefeed.
Fixes #101779