Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/opt: deflake TestExecBuild/autocommit #103792

Merged

Conversation

nvanbenschoten
Copy link
Member

Fixes #103772.

The test became flaky after 3fc29ad, which causes intent resolution to end up in foreground requests' traces.

Release note: None

Fixes cockroachdb#103772.

The test became flaky after 3fc29ad, which causes intent resolution to
end up in foreground requests' traces.

Release note: None
@nvanbenschoten nvanbenschoten requested review from knz and mgartner May 23, 2023 15:44
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner May 23, 2023 15:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten
Copy link
Member Author

bors r=knz

@craig
Copy link
Contributor

craig bot commented May 23, 2023

Build succeeded:

@craig craig bot merged commit e3b7e0c into cockroachdb:master May 23, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/deflake103772 branch May 24, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: flake in TestExecBuild/autocommit due to non-deterministic ResolveIntent in KV batch
3 participants