-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: add new dependency to gopenpgp #103720
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch adds a new dependency to github.com/ProtonMail/gopenpgp, which will be used to help implement some of the remaining unimplemented pgcrypto functions. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following dependencies are problematic:
- https://github.com/ProtonMail/go-crypto - implements its own cryptography
- https://github.com/bwesterb/go-ristretto - implements its own cryptography
- https://github.com/cloudflare/circl - implements its own cryptography
There are two major problems with these new dependencies:
-
they implement their own cryptography, which is generally a no-no.
Reference: see all the content available elsewhere already -- https://duckduckgo.com/?q=do+not+implement+your+own+cryptography
It seems unreasonable to import so much untrusted code doing who-knows-what with cryptography just to implement some esoteric pgcrypto functions. There's a major imbalance in the cost/benefit trade-off.
-
they use native Go code, which is not going to be routed to a FIPS-enabled implementation during FIPS builds. This means that all the functionality we'd build on top would not enable FIPS compliance for customers. This is a major deviation from our "Customer Trust" and "Enterprise Readiness" goals for v23.1 and beyond.
Internal discussion - https://cockroachlabs.slack.com/archives/CGA9F858R/p1684855555474749 |
We've decided to deprioritize work on PGP related functions for now. |
This patch adds a new dependency to github.com/ProtonMail/gopenpgp,
which will be used to help implement some of the remaining
unimplemented pgcrypto functions.
Informs #21001
Release note: None