roachtest: fix disk-stalled/* roachtests #103680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#103198, I mistakenly constructed a context with a timeout outside the deferral, resulting in the defer'd Unstall always timing out if the remainder of test took longer than a minute. Epic: None Fixes: cockroachdb#103664. Fixes: cockroachdb#103663. Fixes: cockroachdb#103662. Fixes: cockroachdb#103661. Release note: none
jbowens
requested review from
itsbilal,
srosenberg and
smg260
and removed request for
a team
|
This change is |
RaduBerinde
approved these changes
May 19, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @jbowens, @smg260, and @srosenberg)
pkg/cmd/roachtest/tests/disk_stall.go line 167 at r1 (raw file):
// the disk stalled will prevent artifact collection, making debugging // difficult. defer func() {
Heh, I had wanted to ask about this but I mistakenly assumed the entire test is not expected to exceed 1minute.
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #103198, I mistakenly constructed a context with a timeout outside the deferral, resulting in the defer'd Unstall always timing out if the remainder of test took longer than a minute.
Epic: None
Fixes: #103664.
Fixes: #103663.
Fixes: #103662.
Fixes: #103661.
Release note: none