kvserver: deflake TestLeasePreferencesDuringOutage #103636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliher1911
added
backport-22.2.x
backport-23.1.x
|
This change is |
|
Unfortunately this test also flakes when enqueueing replica into replication queue. But it happens very infrequently. So I'll leave it to the next person to look if it ever flakes. Added an assertion message there. |
aliher1911
force-pushed
the
fix_lease_preference_test
branch
3 times, most recently
from
60605f6 to
ce00458
Compare
|
This test is skipped, can you remove the |
erikgrinaker
approved these changes
May 19, 2023
aliher1911
force-pushed
the
fix_lease_preference_test
branch
from
ce00458 to
4918fbd
Compare
Test didn't accomodate for lease type changes on the same leaseholder in its assertions. Release note: None
aliher1911
force-pushed
the
fix_lease_preference_test
branch
from
4918fbd to
9da622d
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test didn't accomodate for lease type changes on the same leaseholder in its assertions.
Release note: None
Fixes #103398