Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: use a simpler method for clamping OID hash #103547

Merged
merged 1 commit into from
May 17, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 17, 2023

This reduces the amount of OID churn and also is simpler, so might perform better. Having less churn is better for backports.

informs #103399
Release note: None

This reduces the amount of OID churn and also is simpler, so might
perform better. Having less churn is better for backports.

Release note: None
@rafiss rafiss requested a review from fqazi May 17, 2023 20:46
@rafiss rafiss requested a review from a team as a code owner May 17, 2023 20:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss
Copy link
Collaborator Author

rafiss commented May 17, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented May 17, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented May 17, 2023

Build succeeded:

@craig craig bot merged commit 8987a9b into cockroachdb:master May 17, 2023
@rafiss rafiss deleted the simpler-oid-hash branch May 18, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants