Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: check schema privileges when dropping role #103545

Merged
merged 1 commit into from
May 23, 2023
Merged

release-22.2: sql: check schema privileges when dropping role #103545

merged 1 commit into from
May 23, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 17, 2023 •
edited by postamar
Loading

Backport 1/1 commits from #103467 on behalf of @postamar.

/cc @cockroachdb/release

Previously, dropping a role which has privileges on a schema did not result in a error. This patch fixes this bug by adding the missing logic which performs this check.

Fixes #102962.

Release note (bug fix): DROP ROLE now correctly returns an 2BP01 error when the given role has been granted privileges on a schema.

Release justification: bug fix

sql: check schema privileges when dropping role
ee62f27 
Previously, dropping a role which has privileges on a schema did not
result in a error. This patch fixes this bug by adding the missing
logic which performs this check.

Fixes #102962.

Release note (bug fix): DROP ROLE now correctly returns an 2BP01 error
when the given role has been granted privileges on a schema.
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 17, 2023 20:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-103467 branch from 2101078 to 7f0103f Compare May 17, 2023 20:36
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label May 17, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-103467 branch from 1f123a5 to ee62f27 Compare May 17, 2023 20:36
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label May 17, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented May 17, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from rafiss May 17, 2023 20:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar merged commit 25944ae into release-22.2 May 23, 2023
@postamar postamar deleted the blathers/backport-release-22.2-103467 branch May 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@postamar postamar

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @postamar