Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Revert server.shutdown.jobs_wait to 0 #103528

Merged
merged 1 commit into from
May 19, 2023

Conversation

miretskiy
Copy link
Contributor

@miretskiy miretskiy commented May 17, 2023

Revert default setting for server.shutdown.jobs_wait to 0
to ensure that shutdown dows not wait for active jobs.

Issues: none
Epic: None

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented May 17, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy force-pushed the draino branch 3 times, most recently from 5d84ea2 to e4b4c0b Compare May 18, 2023 17:31
@miretskiy miretskiy marked this pull request as ready for review May 18, 2023 17:32
@miretskiy miretskiy requested review from a team as code owners May 18, 2023 17:32
@miretskiy miretskiy changed the title Draino server: Revert server.shutdown.jobs_wait to 0 May 18, 2023
@miretskiy miretskiy requested a review from knz May 18, 2023 17:33
@knz
Copy link
Contributor

knz commented May 19, 2023

you may need to run dev generate docs before this can merge.

Revert default setting for `server.shutdown.jobs_wait` to 0
to ensure that shutdown dows not wait for active jobs.

Release note: None
@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 19, 2023

Build succeeded:

@craig craig bot merged commit 0bd4172 into cockroachdb:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants