-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade golang.org/x/{crypto,mod,net,sys,text,tools,term} #103446
Conversation
4013276
to
0a650c8
Compare
0a650c8
to
0b79969
Compare
This patch updates the following core dependencies as follows: * golang.org/x/crypto from v0.6.0 to v0.7.0 * golang.org/x/mod from v0.7.0 to v0.8.0 * golang.org/x/net from v0.7.0 to v0.8.0 * golang.org/x/sys from v0.5.0 to v0.6.0 * golang.org/x/text from v0.7.0 to v0.8.0 * golang.org/x/tools from v0.1.12 to v0.6.0 * golang.org/x/term from v0.5.0 to v0.6.0 Also update `rules_go` to a compatible version (0.38). Release note: None
0b79969
to
161de46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
looking at the diffs in each repo,
|
Of these, the upgrade of x/tools is the largest one. It's going to take a little longer to look at. |
Ok actually most of the changes in x/tools pertain to gopls, which we don't import in crdb. The remaining changes are on the analysis packages. They are all beneficial to us. |
For references:
|
Thanks for the in-depth review! bors r=rafiss,knz |
This PR was included in a batch that timed out, it will be automatically retried |
This PR was included in a batch that timed out, it will be automatically retried |
Build succeeded: |
blathers backport 23.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 161de46 to blathers/backport-release-23.1-103446: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch updates the following core dependencies as follows:
Also update
rules_go
to a compatible version (0.38).Informs #21001
Release note: None