Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: add expiration lease escape hatch #103352

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 1/1 commits from #103278.

/cc @cockroachdb/release


This patch adds COCKROACH_DISABLE_EXPIRATION_LEASES_ONLY, which can be used to hard-disable expiration-based leases, e.g. in cases where the lease extensions overload the cluster and prevent it from working, and thus prevent operators from disabling the setting.

Epic: none
Release note: None

@erikgrinaker erikgrinaker self-assigned this May 15, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner May 15, 2023 21:41
@blathers-crl
Copy link

blathers-crl bot commented May 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented May 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker requested a review from a team May 16, 2023 07:17
This patch adds `COCKROACH_DISABLE_EXPIRATION_LEASES_ONLY`, which can be
used to hard-disable expiration-based leases, e.g. in cases where the
lease extensions overload the cluster and prevent it from working, and
thus prevent operators from disabling the setting.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the backport23.1-103278 branch from 54d5986 to 2981c14 Compare May 16, 2023 07:46
@erikgrinaker erikgrinaker merged commit 180fea6 into cockroachdb:release-23.1 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants