Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: pg_catalog: use 0 for pg_constraint.conparentid #103232

Merged
merged 1 commit into from
May 15, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 12, 2023

Backport 1/1 commits from #103143 on behalf of @rafiss.

/cc @cockroachdb/release


fixes #103135

The Postgres docs say this is:

The corresponding constraint of the parent partitioned table,
if this is a constraint on a partition; else zero.

Since we don't support partitioning like Postgres, we should always make this zero.

This fixes a query that a tool was using to identify foreign key relationships.

Release note (bug fix): Stopped using a NULL value for pg_constraint.conparentid. Now the value is hard-coded to 0, since CockroachDB does not support constraints on partitions.


Release justification: bug fix

The Postgres docs say this is:
> The corresponding constraint of the parent partitioned table,
  if this is a constraint on a partition; else zero.

Since we don't support partitioning like Postgres, we should always make
this zero.

This fixes a query that a tool was using to identify foreign key
relationships.

Release note (bug fix): Stopped using a NULL value for
pg_constraint.conparentid. Now the value is hard-coded to 0, since
CockroachDB does not support constraints on partitions.
@blathers-crl blathers-crl bot requested a review from a team May 12, 2023 20:51
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-103143 branch from 4acdc30 to 97fbf22 Compare May 12, 2023 20:51
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label May 12, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-103143 branch from 3a6751f to 832450a Compare May 12, 2023 20:51
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label May 12, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented May 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit ca300ad into release-22.2 May 15, 2023
@rafiss rafiss deleted the blathers/backport-release-22.2-103143 branch May 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants