Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: backupccl: support materialized view mutation in restore #103231

Merged
merged 1 commit into from
Jun 13, 2023
Merged

release-22.2: backupccl: support materialized view mutation in restore #103231

merged 1 commit into from
Jun 13, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 12, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #102516 on behalf of @rafiss.

/cc @cockroachdb/release

fixes #101075

Release note (bug fix): Fixed a bug that could prevent RESTORE from working if the backup had a refresh materialized view mutation in it.

Release justification: bug fix

@blathers-crl blathers-crl bot requested a review from a team as a code owner May 12, 2023 20:51
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-102516 branch from 4acdc30 to 0da3e69 Compare May 12, 2023 20:51
@blathers-crl blathers-crl bot requested review from adityamaru and removed request for a team May 12, 2023 20:51
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label May 12, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-102516 branch from 7f387be to bede476 Compare May 12, 2023 20:51
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label May 12, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented May 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from fqazi, rhu713 and a team May 12, 2023 20:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

fqazi
fqazi approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @adityamaru and @rhu713)

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@adityamaru
Copy link
Contributor

friendly ping @rafiss!

@rafiss
backupccl: support materialized view mutation in restore
41a717f 
Release note (bug fix): Fixed a bug that could prevent RESTORE from
working if the backup had a refresh materialized view mutation in it.
@rafiss rafiss force-pushed the blathers/backport-release-22.2-102516 branch from bede476 to 41a717f Compare June 13, 2023 19:28
@rafiss rafiss merged commit f87e6a9 into release-22.2 Jun 13, 2023
@rafiss rafiss deleted the blathers/backport-release-22.2-102516 branch June 13, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi fqazi approved these changes

@adityamaru adityamaru Awaiting requested review from adityamaru adityamaru is a code owner automatically assigned from cockroachdb/disaster-recovery

@rhu713 rhu713 Awaiting requested review from rhu713

Assignees

@rafiss rafiss

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @adityamaru @fqazi @rafiss