Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: fix a bug in the previous commit #103223

Merged
merged 1 commit into from
May 24, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented May 12, 2023

This was a shortcoming in #103034.

The closing '}' in the representation of OperationMetadata is an unredactable safe string.

I will send a separate PR with a unit test.

Release note: None
Epic: CRDB-27642

@knz knz requested review from abarganier and a team May 12, 2023 20:03
@blathers-crl
Copy link

blathers-crl bot commented May 12, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@knz
Copy link
Contributor Author

knz commented May 24, 2023

TFYR!

bors r=abargainier

The closing '}' in the representation of OperationMetadata is an
unredactable safe string.

Release note: None
@knz knz force-pushed the 20230512-trace-fix branch from 3675ddb to eae4a13 Compare May 24, 2023 12:47
@craig
Copy link
Contributor

craig bot commented May 24, 2023

Canceled.

@knz
Copy link
Contributor Author

knz commented May 24, 2023

bors r=abargainier

@craig
Copy link
Contributor

craig bot commented May 24, 2023

Build succeeded:

@craig craig bot merged commit 24a32f2 into cockroachdb:master May 24, 2023
@knz knz deleted the 20230512-trace-fix branch May 24, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants