Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: add USING clause to DELETE statement diagram #103115

Merged
merged 1 commit into from
May 12, 2023

Conversation

taroface
Copy link
Collaborator

Add the USING clause to the DELETE statement diagram. This was implemented in #40963.

Epic: none

Release note: none

Release justification: non-production code change

@taroface taroface requested a review from yuzefovich May 11, 2023 15:30
@blathers-crl
Copy link

blathers-crl bot commented May 11, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

bors r=yuzefovich

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @taroface)

@craig
Copy link
Contributor

craig bot commented May 12, 2023

Build succeeded:

@craig craig bot merged commit 117dc40 into cockroachdb:master May 12, 2023
@taroface
Copy link
Collaborator Author

blathers backport 23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants