Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: delete unused VerifyNoImports function and package #103059

Merged

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented May 10, 2023

The functionality here is replaced with our disallowed_imports_test
macro.

Epic: none
Release note: None

@rickystewart rickystewart requested a review from healthy-pod May 10, 2023 19:41
@rickystewart rickystewart requested review from a team as code owners May 10, 2023 19:41
@rickystewart rickystewart requested review from a team May 10, 2023 19:41
@rickystewart rickystewart requested a review from a team as a code owner May 10, 2023 19:41
@rickystewart rickystewart requested review from a team, yuzefovich and lidorcarmel and removed request for a team May 10, 2023 19:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart requested a review from rail May 10, 2023 19:41
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it with 🔥

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

It'd be helpful to explain in the commit message that it's been replaced with Bazel's disallowed_imports_test macro.

The functionality here is replaced with our `disallowed_imports_test`
macro.

Epic: none
Release note: None
@rickystewart rickystewart force-pushed the delete-unused-verifynoimports branch 2 times, most recently from 5a3e2cd to d18ef5e Compare May 10, 2023 20:02
@rickystewart
Copy link
Collaborator Author

bors r=rail,mgartner

@craig
Copy link
Contributor

craig bot commented May 10, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants