kvstorage: number stores separately from node IDs #102968
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently discovered that a lot of our observability surfaces have created confusion -- or rather, a mistaken assumption -- that store IDs and node IDs are interchangeable. As we start to see more and more deployments with multiple stores per node, this assumption gets invalidated more and more often, with gross correctness results in interpreting metrics and other observability data. To improve this situation, this commit changes the store numbering to start at 123. In addition, it increases the stride between store IDs to 3 to ensure that the difference between node ID and store ID doesn't appear to be simple in the common case. Release note (backward-incompatible change): CockroachDB now uses a different mechanism to number stores, separate from the allocation of node IDs. While the two concepts have historically always be different, it is possible that some audiences were confused and mistakenly assumed they were interchangeable. Any previous automation built on top of that assumption should be adjusted to relate a store ID back to the node ID using the node/store metatadata.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #102967.
We recently discovered that a lot of our observability surfaces have created confusion -- or rather, a mistaken assumption -- that store IDs and node IDs are interchangeable.
As we start to see more and more deployments with multiple stores per node, this assumption gets invalidated more and more often, with gross correctness results in interpreting metrics and other observability data.
To improve this situation, this commit changes the store numbering to start at 123. In addition, it increases the stride between store IDs to 3 to ensure that the difference between node ID and store ID doesn't appear to be simple in the common case.
Release note (backward-incompatible change): CockroachDB now uses a different mechanism to number stores, separate from the allocation of node IDs. While the two concepts have historically always be different, it is possible that some audiences were confused and mistakenly assumed they were interchangeable. Any previous automation built on top of that assumption should be adjusted to relate a store ID back to the node ID using the node/store metatadata.