-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: add failover
variants with expiration leases
#102916
roachtest: add failover
variants with expiration leases
#102916
Conversation
Expiration-based leases have different availability properties than epoch leases under most failure modes. This patch adds `failover` test variants that use expiration-based leases only. Epic: none Release note: None
d975177
to
8cafeae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the name will be unchanged for non-expiration leases which is excellent!
Have you run all these tests already? Do they all pass with better results than non-expiration? I'm not sure it makes much sense to backport this "soon" as we should ensure no flakiness associated with these tests by letting them bake for a couple of weeks on master.
TFTR! Haven't run them yet, will let the nightlies do it. I agree with letting it bake for a bit, but will open the backports now. bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 8cafeae to blathers/backport-release-23.1-102916: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Expiration-based leases have different availability properties than epoch leases under most failure modes. This patch adds
failover
test variants that use expiration-based leases only.Epic: none
Release note: None