Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add failover variants with expiration leases #102916

Merged

Conversation

erikgrinaker
Copy link
Contributor

Expiration-based leases have different availability properties than epoch leases under most failure modes. This patch adds failover test variants that use expiration-based leases only.

Epic: none
Release note: None

@erikgrinaker erikgrinaker requested review from nvanbenschoten, andrewbaptist and a team May 8, 2023 21:40
@erikgrinaker erikgrinaker self-assigned this May 8, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner May 8, 2023 21:40
@erikgrinaker erikgrinaker requested review from herkolategan and renatolabs and removed request for a team May 8, 2023 21:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Expiration-based leases have different availability properties than
epoch leases under most failure modes. This patch adds `failover` test
variants that use expiration-based leases only.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the roachtest-failover-expiration-leases branch from d975177 to 8cafeae Compare May 8, 2023 21:41
@erikgrinaker erikgrinaker added the backport-23.1.x Flags PRs that need to be backported to 23.1 label May 8, 2023
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

It looks like the name will be unchanged for non-expiration leases which is excellent!

Have you run all these tests already? Do they all pass with better results than non-expiration? I'm not sure it makes much sense to backport this "soon" as we should ensure no flakiness associated with these tests by letting them bake for a couple of weeks on master.

@erikgrinaker
Copy link
Contributor Author

TFTR! Haven't run them yet, will let the nightlies do it. I agree with letting it bake for a bit, but will open the backports now.

bors r+

@craig
Copy link
Contributor

craig bot commented May 10, 2023

Build succeeded:

@craig craig bot merged commit 506a55a into cockroachdb:master May 10, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 8cafeae to blathers/backport-release-23.1-102916: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@erikgrinaker erikgrinaker deleted the roachtest-failover-expiration-leases branch May 11, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants