workload: remove initial prefix from bank workload payload #102907
Conversation
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @srosenberg)
renatolabs
force-pushed
the
rc/drop-initial-prefix-bank-workload
branch
from
7ef0474 to
ad8bd70
Compare
There was a problem hiding this comment.
It was introduced about 6 years ago [1] and its purpose at the time is not clear.
Looking at that PR, I am also not sure. Maybe it was intended to be used for benchmarking? E.g., csv workload has a microbenchmarks that relies on InitialRows.
Reviewable status:
|
TFTRs! bors r=herkolategan,srosenberg |
|
bors r- |
|
Canceled. |
An `initial-` prefix is added to the payload column of the `bank`
table when the workload is initialized. It was introduced about 6
years ago [1] and its purpose at the time is not clear. There are two
main problems with it:
* the `initial-` prefix suggests the payload may be updated, but that
actually never happens.
* as currently implemented, it assumes that the `payload-bytes`
command line flag is at least `len([]byte("initial-"))`. Passing a
lower value to that command line flag leads to a panic. This is an
implicit assumption that should not exist.
This changes the row generation function so that `payload-bytes` bytes
are randomly generated and inserted into the `payload` column, without
the `initial-` prefix.
[1] d49d535
Epic: none
Release note: None
renatolabs
force-pushed
the
rc/drop-initial-prefix-bank-workload
branch
from
ad8bd70 to
90a9904
Compare
I realized I quoted the wrong commit, there's a parent commit that actually introduced the bors r=herkolategan,srosenberg |
|
Build succeeded: |
An
initial-prefix is added to the payload column of thebanktable when the workload is initialized. It was introduced about 6 years ago [1] and its purpose at the time is not clear. There are two main problems with it:initial-prefix suggests the payload may be updated, but that actually never happens.payload-bytescommand line flag is at leastlen([]byte("initial-")). Passing a lower value to that command line flag leads to a panic. This is an implicit assumption that should not exist.This changes the row generation function so that
payload-bytesbytes are randomly generated and inserted into thepayloadcolumn, without theinitial-prefix.[1] d49d535
Epic: none
Release note: None