Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: fix backup restore tests for public schema to expect an error #102889

Merged
merged 1 commit into from
May 8, 2023
Merged

backupccl: fix backup restore tests for public schema to expect an error #102889

merged 1 commit into from
May 8, 2023

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented May 8, 2023

Fix TestBackupRestoreTelemetryForPublicSchema and public-system-schema to expect a key rewriter error.

Fixes: #102834

Release note: None

backupccl: fix backup restore tests for public schema to expect an error
b357db6 
Fix TestBackupRestoreTelemetryForPublicSchema and public-system-schema
to expect a key rewriter error.

Fixes: cockroachdb#102834

Release note: None
@rhu713 rhu713 requested a review from a team as a code owner May 8, 2023 15:34
@rhu713 rhu713 requested review from lidorcarmel and removed request for a team May 8, 2023 15:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 requested review from msbutler and removed request for lidorcarmel May 8, 2023 15:34
msbutler
msbutler approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a temporary deflaking of these tests. I think we should discuss with the larger team how we ought to handle Restores of system DATABASE/TABLEs

@rhu713 rhu713 merged commit 6ae35be into cockroachdb:release-22.2 May 8, 2023
@stevendanna stevendanna mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbutler msbutler msbutler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhu713 @cockroach-teamcity @msbutler