concurrency: cleanup lock table datadriven tests #102775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup from cockroachdb#102647. In that patch, we decided to translate the strength field on a lock table guard back to a `SpanAccess` to defer some test churn. This patch addresses that TODO; it's entirely mechanical. Informs: cockroachdb#102008 Release note: None
|
This change is |
nvanbenschoten
approved these changes
May 5, 2023
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, 21 of 21 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/concurrency/lock_table_test.go line 717 at r2 (raw file):
sa = spanset.SpanReadWrite default: d.Fatalf(t, "unsupported span strength: %s", str)
nit: I don't think "span strength" is a defined term. It's just "strength" or "lock strength".
In 5418acd we switched to declaring lock spans using lock strength instead of span access; this patch changes datadriven test input for lock table tests to do the same. Closes cockroachdb#102008 Release note: None
Cleanup a few places where we were still referencing/using spanset.SpanAccess or spanset.SpanScope. Of note is a change to `tryClearLocks`, where we forgot to remove a loop over `spanset.SpanScope` in 1cf1508. Epic: none Release note: None
arulajmani
force-pushed
the
concurrency-testing-cleanup
branch
from
3f092d2 to
8a8069a
Compare
arulajmani
commented
May 5, 2023
There was a problem hiding this comment.
TFTR!
bors r=nvanbenschoten
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Last bits of cleanup in support of #102008; the linked issue can be considered completed once this PR lands.