kvserver: only return range info when ClientRangeInfo set

[erikgrinaker]

Previously, passing an empty ClientRangeInfo would always generate and return range info, because the zero values are always considered stale. An exception was made for lease requests, since these bypass DistSender and never use ClientRangeInfo.

This patch instead only returns range info when a non-empty ClientRangeInfo is passed, with a version gate for 23.1 compatibility.

Epic: none
Release note: None

[cockroach-teamcity]

This change is 

[erikgrinaker]

See prior discussion in #100432.

Going to let this sit for a little while to get the previous PR some baking time before the backport.

[erikgrinaker]

#100432 has been baking for a couple of weeks now and the backport will merge shortly, so I think we can review this now @arulajmani.

[andrewbaptist]

I'll let Arul review/approve this one.

[arulajmani]

Thanks for coming back and cleaning this up!

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)

---

pkg/kv/kvserver/replica_send.go line 322 at r1 (raw file):

		}
	} else if ba.IsSingleRequestLeaseRequest() {
		// Remove this branch when 23.1 support is dropped.

nit: want to adopt the TODO for this?

[erikgrinaker]

TFTR! There was a subtle bug here: LeaseSpeculative() would return false if the token did not have a lease. This meant that we wouldn't request cache info when we had a range descriptor with generation and no lease. Updated the code to be obviously correct by checking the exact values we're putting into the struct.

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @arulajmani)

---

pkg/kv/kvserver/replica_send.go line 322 at r1 (raw file):

Previously, arulajmani (Arul Ajmani) wrote…

nit: want to adopt the TODO for this?

Done.

[erikgrinaker]

bors r+

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)