Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: sqlstats: only include local region in statement_statistics #102330

Merged
merged 1 commit into from
Apr 26, 2023
Merged

release-23.1.0: sqlstats: only include local region in statement_statistics #102330

merged 1 commit into from
Apr 26, 2023

Conversation

matthewtodd
Copy link
Contributor

@matthewtodd matthewtodd commented Apr 26, 2023

Backport 1/1 commits from #102192.

/cc @cockroachdb/release


Part of #89949.

Addresses #98020.
Addresses #99563.

Related to cockroachdb/roachperf#129.
Related to #102170.

Previously, we attempted to record all the regions hit in a single statement execution in the sqlstats tables, leaning on the sqlAddressResolver to map traced nodeIDs to localities at execution time.

While the sqlAddressResolver is generally non-blocking, the introduction of this code did cause some of the multiregion "this query shouldn't span regions" tests to start flaking and it's more recently been implicated in a 2.5% performance regression.

Given that the probabilistic nature of the tracing meant that we generally weren't capturing all the relevant nodeIDs anyway, it seems like the most prudent thing to do here is take a step back and regroup.

In the short term, let's stop even trying to gather all these regions. In the medium/long term, let's see if we can find a better approach.

Release note: None

Release justification: fixes for high-priority or high-severity bugs in existing functionality

Part of #89949.

Addresses #98020.
Addresses #99563.

Related to cockroachdb/roachperf#129.
Related to #102170.

Previously, we attempted to record all the regions hit in a single
statement execution in the sqlstats tables, leaning on the
sqlAddressResolver to map traced nodeIDs to localities at execution
time.

While the sqlAddressResolver is generally non-blocking, the introduction
of this code did cause some of the multiregion "this query shouldn't
span regions" tests to start [flaking][] and it's more recently been
[implicated][] in a 2.5% performance regression.

Given that the probabilistic nature of the tracing meant that we
generally weren't capturing all the relevant nodeIDs anyway, it seems
like the most prudent thing to do here is take a step back and regroup.

In the short term, let's stop even trying to gather all these regions.
In the medium/long term, let's see if we can find a better approach.

[flaking]: #98020
[implicated]: https://github.com/cockroachdb/roachperf/pull/129

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Apr 26, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@matthewtodd matthewtodd requested a review from j82w April 26, 2023 14:42
@matthewtodd matthewtodd marked this pull request as ready for review April 26, 2023 16:27
@matthewtodd matthewtodd requested a review from a team April 26, 2023 16:27
@matthewtodd matthewtodd requested a review from a team as a code owner April 26, 2023 16:27
@matthewtodd matthewtodd requested a review from rytaft April 26, 2023 16:27
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

@matthewtodd matthewtodd merged commit 57b9a06 into cockroachdb:release-23.1.0 Apr 26, 2023
@matthewtodd matthewtodd deleted the backport23.1.0-102192 branch April 26, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants