Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowinfra: remove stale TODO #102297

Merged
merged 1 commit into from
Apr 26, 2023
Merged

flowinfra: remove stale TODO #102297

merged 1 commit into from
Apr 26, 2023

Conversation

yuzefovich
Copy link
Member

I don't think the code movement proposed in the TODO makes sense anymore.

Epic: None

Release note: None

I don't think the code movement proposed in the TODO makes sense
anymore.

Epic: None

Release note: None
@yuzefovich yuzefovich requested review from a team and rharding6373 April 26, 2023 00:39
@blathers-crl
Copy link

blathers-crl bot commented Apr 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 26, 2023

Build succeeded:

@craig craig bot merged commit c2ceeb7 into cockroachdb:master Apr 26, 2023
@yuzefovich yuzefovich deleted the todo branch April 26, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants