Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: storage: fatal on corruption encountered in background #102274

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 25, 2023

Backport 1/1 commits from #102252 on behalf of @jbowens.

/cc @cockroachdb/release


Previously, on-disk corruption would only fatal the node if an interator observed it. Corruption encountered by a background job like a compaction would not fatal the node. This can result in busy churning through compactions that repeatedly fail, impacting cluster stability and user query latencies.

Now, on-disk corruption results in immediately exiting the node.

Epic: none
Fixes: #101101
Release note (ops change): When local corruption of data is encountered by a background job, a node will now exit immediately.


Release justification: Very low-risk change to resolve an issue that can affect cluster stability.

Previously, on-disk corruption would only fatal the node if an interator
observed it. Corruption encountered by a background job like a compaction would
not fatal the node. This can result in busy churning through compactions that
repeatedly fail, impacting cluster stability and user query latencies.

Now, on-disk corruption results in immediately exiting the node.

Epic: none
Fixes: #101101
Release note (ops change): When local corruption of data is encountered by a
background job, a node will now exit immediately.
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 25, 2023 18:46
@blathers-crl blathers-crl bot requested a review from sumeerbhola April 25, 2023 18:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-102252 branch 2 times, most recently from 6cdac3c to b2c07b6 Compare April 25, 2023 18:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 25, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 25, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from itsbilal April 25, 2023 18:46
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 25, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot requested a review from RaduBerinde April 25, 2023 18:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbowens jbowens merged commit 86a86b1 into release-23.1 Apr 26, 2023
@jbowens jbowens deleted the blathers/backport-release-23.1-102252 branch April 26, 2023 22:25
@jbowens
Copy link
Collaborator

jbowens commented Apr 26, 2023

TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants