storage: fix setting shared creator ID #102263
Merged
+19
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AtLeast` version check was incorrect and we weren't setting the Creator ID. The code is improved to also set the Creator ID when the version is bumped. We are missing unit tests for shared storage but there is currently no way to use a test / in-memory shared store; we will add tests when we address this. Epic: none Release note: None
|
This change is |
|
TFTR! bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build failed (retrying...): |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AtLeastversion check was incorrect and we weren't setting the Creator ID.The code is improved to also set the Creator ID when the version is bumped.
We are missing unit tests for shared storage but there is currently no way to use a test / in-memory shared store; we will add tests when we address this.
Epic: none
Release note: None