Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: ui: display configurable timezone in DB Console #102241

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

zachlite
Copy link
Contributor

Backport 1/1 commits from #101752.

/cc @cockroachdb/release

Release Justification: Unblock Onboarding


This commit makes it so all timestamps displayed in DB Console (with the exception of Advanced Debug pages) use the timezone set by the cluster setting ui.display_timezone.

Only Coordinated Universal Time and America/New_York are supported. Supporting additional timezones can be achieved by adding more timezones to the enum passed to ui.display_timezone when the setting is registered, and modifying the webpack configs to make sure the relevant timezone data is included. See #99848 for more details.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-5536
Release note (ui): Added the ability for users to view timestamps in DB Console in their preferred timezone via the cluster setting ui.display_timezone. Currently supported timezones are Coordinated Universal Time and America/New_York.

Loom: https://www.loom.com/share/9533173bf68e45f4ac6a09860b04b98a

This commit makes it so all timestamps displayed in
DB Console (with the exception of Advanced Debug pages) use the timezone
set by the cluster setting `ui.display_timezone`.

Only Coordinated Universal Time and America/New_York are supported.
Supporting additional timezones can be achieved by adding more
timezones to the enum passed to `ui.display_timezone`
when the setting is registered, and modifying the webpack configs
to make sure the relevant timezone data is included. See cockroachdb#99848
for more details.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-5536
Release note (ui): Added the ability for users to view timestamps
in DB Console in their preferred timezone via the cluster setting
`ui.display_timezone`. Currently supported timezones are Coordinated
Universal Time and America/New_York.
@zachlite zachlite requested a review from a team April 25, 2023 14:31
@blathers-crl
Copy link

blathers-crl bot commented Apr 25, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@zachlite zachlite merged commit f468bd8 into cockroachdb:release-23.1.0 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants