Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: delete (hlc.Timestamp).DeprecatedTryToClockTimestamp #102155

Merged

Conversation

nvanbenschoten
Copy link
Member

Informs #101938.

This function has been possible to delete since v23.1.

Release note: None

This function has been possible to delete since v23.1.

Epic: None
Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner April 24, 2023 16:08
@blathers-crl
Copy link

blathers-crl bot commented Apr 24, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 25, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Apr 26, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Apr 26, 2023

Build succeeded:

@craig craig bot merged commit 2f42310 into cockroachdb:master Apr 26, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/firstSynTimestamp branch April 27, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants