release-23.1.0: sql: fix the pretty-printing of CREATE EXTENSION

pkg/sql/create_extension.go

@@ -35,7 +35,7 @@ func (n *createExtensionNode) unimplementedExtensionError(issue int) error {
 	name := n.CreateExtension.Name
 	return unimplemented.NewWithIssueDetailf(
 		issue,
-		"CREATE EXTENSION "+name,
+		"CREATE EXTENSION "+string(name),
 		"extension %q is not yet supported",
 		name,
 	)
@@ -48,7 +48,7 @@ func (n *createExtensionNode) startExec(params runParams) error {
 		"fuzzystrmatch",
 		"pgcrypto",
 		"uuid-ossp":
-		telemetry.Inc(sqltelemetry.CreateExtensionCounter(n.CreateExtension.Name))
+		telemetry.Inc(sqltelemetry.CreateExtensionCounter(string(n.CreateExtension.Name)))
 		return nil
 	case "postgis_raster",
 		"postgis_topology",
@@ -105,7 +105,7 @@ func (n *createExtensionNode) startExec(params runParams) error {
 		"xml2":
 		return n.unimplementedExtensionError(54516)
 	}
-	return pgerror.Newf(pgcode.UndefinedParameter, "unknown extension: %q", n.CreateExtension.Name)
+	return pgerror.Newf(pgcode.UndefinedParameter, "unknown extension: %s", n.CreateExtension.Name)
 }
 
 func (n *createExtensionNode) Next(params runParams) (bool, error) { return false, nil }

pkg/sql/parser/sql.y

@@ -4472,10 +4472,10 @@ create_schedule_stmt:
 create_extension_stmt:
   CREATE EXTENSION IF NOT EXISTS name
   {
-    $$.val = &tree.CreateExtension{IfNotExists: true, Name: $6}
+    $$.val = &tree.CreateExtension{IfNotExists: true, Name: tree.Name($6)}
   }
 | CREATE EXTENSION name {
-    $$.val = &tree.CreateExtension{Name: $3}
+    $$.val = &tree.CreateExtension{Name: tree.Name($3)}
   }
 | CREATE EXTENSION IF NOT EXISTS name WITH error
   {

pkg/sql/parser/testdata/create_misc

@@ -9,6 +9,14 @@ CREATE EXTENSION bob -- fully parenthesized
 CREATE EXTENSION bob -- literals removed
 CREATE EXTENSION bob -- identifiers removed
 
+parse
+CREATE EXTENSION "a-b"
+----
+CREATE EXTENSION "a-b"
+CREATE EXTENSION "a-b" -- fully parenthesized
+CREATE EXTENSION "a-b" -- literals removed
+CREATE EXTENSION "a-b" -- identifiers removed
+
 parse
 CREATE EXTENSION IF NOT EXISTS bob
 ----

pkg/sql/sem/tree/create.go

@@ -2118,7 +2118,7 @@ func (o *CreateStatsOptions) CombineWith(other *CreateStatsOptions) error {
 
 // CreateExtension represents a CREATE EXTENSION statement.
 type CreateExtension struct {
-	Name        string
+	Name        Name
 	IfNotExists bool
 }
 
@@ -2133,7 +2133,9 @@ func (node *CreateExtension) Format(ctx *FmtCtx) {
 	// do not contain sensitive information and
 	// 2) we want to get telemetry on which extensions
 	// users attempt to load.
-	ctx.WriteString(node.Name)
+	ctx.WithFlags(ctx.flags&^FmtAnonymize, func() {
+		ctx.FormatNode(&node.Name)
+	})
 }
 
 // CreateExternalConnection represents a CREATE EXTERNAL CONNECTION statement.

pkg/sql/testdata/telemetry/extension

@@ -28,4 +28,4 @@ unimplemented.#54516.CREATE EXTENSION xml2
 feature-usage
 CREATE EXTENSION asdf
 ----
-error: pq: unknown extension: "asdf"
+error: pq: unknown extension: asdf